Skip to content

[Schema] Fix: correct Resource type hints in ListResourcesResult #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CodeWithKyrian wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −6
Open

[Schema] Fix: correct Resource type hints in ListResourcesResult #191

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9459fad
fix: correct Resource type hints in ListResourcesResult
CodeWithKyrian Dec 19, 2025
65d598c
fix: phpstan errors
CodeWithKyrian Dec 19, 2025
6972f02
fix: phpstan errors
CodeWithKyrian Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/Schema/Result/ListResourcesResult.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,20 @@
use Mcp\Exception\InvalidArgumentException;
use Mcp\Schema\JsonRpc\Response;
use Mcp\Schema\JsonRpc\ResultInterface;
use Mcp\Schema\Resource;
use Mcp\Schema\Resource as ResourceSchema;

/**
* The server's response to a resources/list request from the client.
*
* @phpstan-import-type ResourceData from Resource
* @phpstan-import-type ResourceData from ResourceSchema
*
* @author Kyrian Obikwelu <koshnawaza@gmail.com>
*/
class ListResourcesResult implements ResultInterface
{
/**
* @param array<resource> $resources the list of resource definitions
* @param string|null $nextCursor An opaque token representing the pagination position after the last returned result.
* @param array<ResourceSchema> $resources the list of resource definitions
* @param string|null $nextCursor An opaque token representing the pagination position after the last returned result.
*
* If present, there may be more results available.
*/
Expand All @@ -50,14 +50,14 @@ public static function fromArray(array $data): self
}

return new self(
array_map(fn (array $resource) => Resource::fromArray($resource), $data['resources']),
array_map(fn (array $resource) => ResourceSchema::fromArray($resource), $data['resources']),
$data['nextCursor'] ?? null
);
}

/**
* @return array{
* resources: array<resource>,
* resources: array<ResourceSchema>,
* nextCursor?: string,
* }
*/
Expand Down