fix: fixed the bug in subtitle merging

[xiaoxianhjy]

Change Summary

Related issue number

Checklist

• The pull request title is a good summary of the changes - it will be used in the changelog
• Unit tests for the changes exist
• Run pre-commit install and pre-commit run --all-files before git commit, and passed lint check.
• Documentation reflects the changes where applicable

[gemini-code-assist]

Summary of Changes

Hello @xiaoxianhjy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug in the subtitle merging functionality of the video composition agent. The previous implementation was unable to properly integrate multiple subtitle images into a single video segment, leading to incomplete or incorrect subtitle display. The updated logic now dynamically gathers all relevant subtitle files for each segment, calculates their individual display durations, and sequences them correctly within the video, significantly improving the accuracy and completeness of subtitle integration.

Highlights

• Subtitle Merging Logic: The video composition agent now correctly handles and merges multiple subtitle image files for a single video segment, displaying them sequentially.
• Dynamic Subtitle Collection: Subtitle paths are dynamically identified and collected for each segment by searching for indexed files (e.g., bilingual_subtitle_1_0.png, bilingual_subtitle_1_1.png).
• Sequential Playback: Each subtitle image within a segment is assigned a proportional duration and positioned with a start time to ensure accurate sequential display.
• Robustness: Improved error handling for loading subtitle image files has been added to prevent crashes due to invalid or missing files.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a bug in subtitle merging by allowing multiple subtitle images per video segment. The changes look good overall, but I've identified a critical issue that could cause a crash if a video segment lacks a duration. I've provided a suggestion to fix this. Additionally, there's a minor opportunity to improve code clarity by removing a redundant check. Please see the detailed comments below.