Fix web-ui, ignore node_modules and fit the current conda env #830
Conversation
Summary of ChangesHello @tastelikefeet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the web UI's setup process by enhancing Python environment detection and virtual environment management in the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several improvements to the web UI startup process and project configuration. Key changes include adding node_modules to .gitignore, enhancing the Python version check to be more robust, and adding support for existing Conda and virtual environments in webui/start.sh. My review focuses on refining these changes for better stability and adherence to best practices. I've suggested a more precise pattern for .gitignore and a fix in the startup script to handle potential errors during the Python version check, ensuring the script provides clear feedback to the user in all scenarios.
| if [ -z "$PYTHON_CMD" ]; then | ||
| echo -e "${RED}Error: Python 3.10 or higher is required but not found.${NC}" | ||
| echo -e "${YELLOW}Please install Python 3.10+ and try again.${NC}" | ||
| PY_VERSION=$($PYTHON_CMD -c "import sys; print(sys.version_info[:2] >= (3, 10))") |
There was a problem hiding this comment.
With set -e active, if the python command fails (e.g., if it's Python 2, which would cause a SyntaxError), the script will exit immediately without a user-friendly error message. To handle this gracefully, you should catch the error and ensure PY_VERSION is set to a value that will trigger the error condition, like 'False'.
| PY_VERSION=$($PYTHON_CMD -c "import sys; print(sys.version_info[:2] >= (3, 10))") | |
| PY_VERSION=$($PYTHON_CMD -c "import sys; print(sys.version_info[:2] >= (3, 10))" 2>/dev/null || echo "False") |
| nosetests.xml | ||
| coverage.xml | ||
| *.cover | ||
| *node_modules* |
There was a problem hiding this comment.
The pattern *node_modules* is overly broad and may unintentionally ignore files that simply contain node_modules in their name (e.g., documentation files). The standard and safer practice is to use node_modules/, which specifically targets directories named node_modules anywhere in your project.
node_modules/
2 participants
Change Summary
Related issue number
Checklist
pre-commit installandpre-commit run --all-filesbefore git commit, and passed lint check.