fix(rlhf): preserve base weights during LoRA rollout sync - #10154
Closed
taking-lying-flat wants to merge 1 commit into
Closed
taking-lying-flat wants to merge 1 commit into
taking-lying-flat wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HF/DeepSpeed rollout synchronization temporarily merges LoRA into the training model and then subtracts the adapter delta to unmerge. BF16 rounding makes that subtraction an inexact inverse: a synchronization alone can change frozen base weights, even without an optimizer step.
Preserve the original base parameter storage and merge into temporary tensors inside the existing parameter-group gather context. Restore the original parameters and PEFT merge/cache state when the context exits, including on failures. Apply this to both full-weight sync and the existing merge in adapter-only sync.
The change keeps the existing parameter groups, transport calls, adapter dtype alignment, and outgoing payload layout. It does not introduce additional transfer batches or write model copies to disk. Temporary base tensors do add memory proportional to the merged parameters in the current group; with
move_model_batches=None, that group can cover the whole model.Validation:
Only production code is included. Related numerical mechanism: #10087 discusses BF16 merge/unmerge perturbation in the Megatron save path; this change addresses the HF rollout synchronization path.