Skip to content

fix(storage): preserve WAL on checkpoint failure #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WangXukang-cypher wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(storage): preserve WAL on checkpoint failure #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/sirchmunk/storage/duckdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,19 +119,17 @@ def _checkpoint_wal(db_file: str):
logger.info(
f"Stale WAL detected at {wal_file}, checkpointing before load"
)
tmp_conn = None
try:
tmp_conn = duckdb.connect(db_file)
tmp_conn.execute("CHECKPOINT")
tmp_conn.close()
logger.info(f"WAL checkpoint completed for {db_file}")
except Exception as e:
logger.warning(f"WAL checkpoint failed for {db_file}: {e}")
# Last resort: remove the stale WAL so READ_ONLY ATTACH can proceed
try:
wal_file.unlink()
logger.info(f"Removed stale WAL file {wal_file}")
except Exception:
pass
logger.error(f"WAL checkpoint failed for {db_file}: {e}")
raise
finally:
if tmp_conn is not None:
tmp_conn.close()

@staticmethod
def _cleanup_wal(db_file: str):
Expand Down