fix: avoid duplicate gradient norm reduction in pure DDP - #290
Open
taking-lying-flat wants to merge 1 commit into
Open
taking-lying-flat wants to merge 1 commit into
taking-lying-flat wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
Pure DDP backward synchronizes complete gradients on every rank, but passing
_dp_groupinto gradient clipping sums their squared norms again. With two ranks, a normalized gradient of0.8is reported as1.131371and incorrectly clipped to0.707106whenmax_grad_norm=1.Use the existing local clipping path when the model is wrapped in
DistributedDataParalleland its mesh contains only data parallelism. Keep the DP group for token-count gathering and retain gradient normalization, scaler handling, and training-state updates. Other parallel configurations keep their existing norm-reduction group.Experiment results
Local validation with PyTorch 2.13.0 and CPU/Gloo, using an out-of-tree harness with real DDP backward and the
TransformersModel.clip_grad_normmethod body:uvx pre-commit run --all-filespassed.For the two-rank
0.8case, the corrected norm and clipped gradient are both0.800000.