Tiered responsive footer + narrow-width navbar fixes#681
Open
LindsayAuch wants to merge 1 commit into
Open
Conversation
Footer (src/theme/Footer/styles.module.css): * Drop the docs-page sticky-to-viewport-bottom rule so the footer flows as the last block element — content no longer scrolls behind it. * Container is now full-width with --ifm-spacing-horizontal padding (instead of 83% width + margin: 0 auto + translateX(-120px)), so it left-aligns with the article column at every viewport instead of drifting toward center at mid widths. * flex-wrap: wrap on the container + white-space: nowrap on the links lets the Give feedback + social cluster drop to a second line when there's no horizontal room — links stay on one line rather than each one breaking. * Below 768px, full vertical stack. * 1px border-left on docs pages (margin-left: 306px) so the sidebar's right-edge divider continues unbroken through the footer. Narrow-width fixes (src/css/custom.css): * At <=996px: zero out --ifm-secondary-nav-height so the breadcrumb doesn't sit below a phantom 48px gap reserved for a non-rendered secondary nav. * At <=996px: pin --ifm-navbar-padding-horizontal and --ifm-spacing-horizontal both to 20px so the hamburger icon and the breadcrumb home icon share a single left edge. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
3 tasks
3 tasks
Contributor
|
Why did we decide to drop the footer from being visible on landing pages without scrolling? Current site: Proposed version: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Footer (`src/theme/Footer/styles.module.css`)
Narrow-width navbar (`src/css/custom.css`)
At `<=996px`:
Test plan
🤖 Generated with Claude Code