Skip to content

Conversation

@wpbonelli
Copy link
Member

Lgr.to_disv_gridprops() left duplicate hanging vertices in the generated grid. Fix it by adding deduplication logic after vertices are collected. Some variables to record hanging vertices already existed, seems like this was intended but left out of the implementation.

Now the only substantive difference between cvfdutil.gridlist_to_disv_gridprops and the Lgr approach is that the former includes "wraparound" vertices, which MF6 considers unnecessary.

Noticed this in MODFLOW-ORG/modflow6-examples#319 while switching to the Lgr approach.

Some of the test code here will be very short-lived given #2667 but I'm including it just to bake it into the git log for the benefit of any future forensics

@wpbonelli wpbonelli added the bug label Dec 20, 2025
@wpbonelli wpbonelli added this to the 3.9.6 milestone Dec 20, 2025
@codecov
Copy link

codecov bot commented Dec 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.7%. Comparing base (556c088) to head (2259125).
⚠️ Report is 98 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2672      +/-   ##
===========================================
+ Coverage     55.5%    72.7%   +17.1%     
===========================================
  Files          644      667      +23     
  Lines       124135   129574    +5439     
===========================================
+ Hits         68947    94222   +25275     
+ Misses       55188    35352   -19836     
Files with missing lines Coverage Δ
flopy/utils/cvfdutil.py 84.0% <ø> (+1.5%) ⬆️
flopy/utils/lgrutil.py 97.4% <100.0%> (+0.1%) ⬆️

... and 558 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpbonelli wpbonelli marked this pull request as ready for review December 20, 2025 11:50
@wpbonelli wpbonelli merged commit ada6e63 into modflowpy:develop Dec 20, 2025
19 checks passed
@wpbonelli wpbonelli deleted the lgr-hanging-vertex-fix branch December 20, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant