Conversation
Comment on lines
113
to
116
| final List<TicketAnalyticsResponse.DailyTicket> dailyTickets = analyticsRepository.aggregateDailyTicketCounts(server, startDate, ANALYTICS_TIME_ZONE) | ||
| .stream() | ||
| .map(result -> new TicketAnalyticsResponse.DailyTicket( | ||
| formatDateLabel(result.id(), dateFormatter), | ||
| result.count() | ||
| )) | ||
| .map(result -> new TicketAnalyticsResponse.DailyTicket(result.id(), result.count())) | ||
| .toList(); |
There was a problem hiding this comment.
Preserve chart labels
The analytics API now returns raw aggregation keys like 2026-03-12 instead of the previous MMM dd labels for date-based chart series. This affects dailyTickets here and the same changed mapping for dailyPunishments and newPlayersTrend, so existing panel/minecraft clients that render these fields as display labels will show the wrong format after this hotfix.
Rule Used: This is a Java Spring Boot REST API backed by Mong... (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/main/java/gg/modl/backend/analytics/service/AnalyticsService.java
Line: 113-116
Comment:
**Preserve chart labels**
The analytics API now returns raw aggregation keys like `2026-03-12` instead of the previous `MMM dd` labels for date-based chart series. This affects `dailyTickets` here and the same changed mapping for `dailyPunishments` and `newPlayersTrend`, so existing panel/minecraft clients that render these fields as display labels will show the wrong format after this hotfix.
**Rule Used:** This is a Java Spring Boot REST API backed by Mong... ([source](https://app.greptile.com/modl-gg/github/modl-gg/backend/-/custom-context?memory=b4136624-5265-466d-9689-920e361bc645))
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confidence Score: 4/5
This PR has one contained analytics response regression to fix before merging.
The functional changes are narrow, but
AnalyticsServicechanges a client-visible date format for daily chart data.src/main/java/gg/modl/backend/analytics/service/AnalyticsService.java
What T-Rex did
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "LF + audit/analytics" | Re-trigger Greptile
Context used: