bugfix pdoResources snippet, $output string to placeholders

[arjen-t]

Что оно делает?

Check if $ouput is an array before adding the $log result when property $toSeparatePlaceholders is set.

Зачем это нужно?

Uncaught TypeError in PHP >= 8

Связанные проблема(ы)/PR(ы)

#372

[Ibochkarev]

The wrong variable is being checked.

• Problem: $output can be a string (when called via pdoPage with toSeparatePlaceholders), but the code does $output['log'] = $log, which in PHP 8 results in TypeError: Cannot access offset of type string.
• In the code: $log is always a string (or an empty string), since it is formed as $log .= ' ' . print_r($pdoFetch->getTime(), 1) . ' '.
• Consequence: the is_array($log) condition is almost always false, the else branch is executed, and only ['log' => $log] is included in placeholders, while the contents of $output are lost.

You need to check $output, not $log:

} elseif (!empty($toSeparatePlaceholders)) {
    if (is_array($output)) {
        $output['log'] = $log;
        $modx->setPlaceholders($output, $toSeparatePlaceholders);
    } else {
        $modx->setPlaceholders(['output' => $output, 'log' => $log], $toSeparatePlaceholders);
    }
}

• If $output is an array: add log and set all placeholders from $output.
• If $output is a string: set output and log as separate placeholders.