Add scriptProperties values as placeholder to the pagination#392
Open
Jako wants to merge 1 commit intomodx-pro:masterfrom
Open
Add scriptProperties values as placeholder to the pagination#392Jako wants to merge 1 commit intomodx-pro:masterfrom
Jako wants to merge 1 commit intomodx-pro:masterfrom
Conversation
Ibochkarev
requested changes
Mar 8, 2026
Member
There was a problem hiding this comment.
If for some reason it turns out to be null, array_merge(null, $pagination) will throw an error in PHP 8+.
Let's add some protection:
$pageNavVar => !empty($tplPageWrapper)
? $pdoPage->pdoTools->getChunk($tplPageWrapper, array_merge((array) ($scriptProperties ?? []), $pagination))
: $pdoPage->pdoTools->parseChunk('', array_merge((array) ($scriptProperties ?? []), $pagination)),or
$pagePlaceholders = array_merge((array) ($scriptProperties ?? []), $pagination);
$pageNavVar => !empty($tplPageWrapper)
? $pdoPage->pdoTools->getChunk($tplPageWrapper, $pagePlaceholders)
: $pdoPage->pdoTools->parseChunk('', $pagePlaceholders),
Contributor
Author
|
I am quite sure that $scriptProperties is an array all the time. Otherwise the code will break before. |
Ibochkarev
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add scriptProperties values as placeholder to the pagination. This is quite useful, if you need to fill special properties into special placeholders in the pagination links. Otherwise you have to create several pagination chunks with the special properties.