new function ChangeField into the manager to change a column without …#13400
Closed
flolopdel wants to merge 1 commit intomodxcms:2.5.xfrom
Closed
new function ChangeField into the manager to change a column without …#13400flolopdel wants to merge 1 commit intomodxcms:2.5.xfrom
flolopdel wants to merge 1 commit intomodxcms:2.5.xfrom
Conversation
…drop the existing content, you must update the schema xml changing the field befor call this function
Collaborator
|
Hi @flolopdel! Thanks, this looks really interesting and I've wondered why we didn't have a method like that before... Unfortunately though this is the wrong place to send that pull request... all changes to xPDO need to go into the main xPDO repo at https://github.com/modxcms/xpdo (probably the 2.x branch - the 3.x branch is newer but wont be incorporated until MODX 3). The xPDO repo gets pulled into MODX at a later point. Maybe worth changing the method name to |
Contributor
|
The PR was opened on xPDO now. So I close it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…drop the existing content, you must update the schema xml changing the field before call this function
What does it do?
Change a existing column without drop the existing content, you must update the schema xml changing the field before call this function
Why is it needed?
To change a column field without drop the old values
Related issue(s)/PR(s)