fix(manager): increase Package Manager drag-and-drop image visibility#16899
fix(manager): increase Package Manager drag-and-drop image visibility#16899Ibochkarev wants to merge 2 commits intomodxcms:3.xfrom
Conversation
Set opacity to 0.25 for #modx-panel-packages.drag-n-drop::before so the dragndrop.svg hint is visible as an intentional UI cue instead of appearing as a bug or artifact. Resolves modxcms#15989
Code ReviewSummaryAdds AssessmentMinimal CSS change, correct and harmless. Improves visibility of the drag-and-drop hint without being intrusive. VerdictApprove |
mkschell
left a comment
There was a problem hiding this comment.
Simple scss/css change, no superfluous whitespace changes, manually verified working.
Thanks!
|
I would also add the another one SVG, since user can only drag and drop archives, and here the images are in SVG. |
|
Guys - I'm of the mind that in the normal state there should be no icon shown. I believe the typical pattern out there is to indicate the drop zone when dragging an object over it. The other thing is, and maybe this is what Ruslan's getting at, the icon itself indicates the movement of literal images — if a graphic is to be shown (preferably on an over state) it should communicate the type of content that's droppable. I do appreciate the effort to fix what's currently showing — it's a little thing that's bothered me for a while ;-) |
|
@smg6511 Any harm in leaving this visibility improvement in flow to be merged for now, and we get a new Issue logged with the additional thoughts raised above? I think those are excellent points and agree with moving to more common patterns. (I don't mind adding the new Issue if you agree.) |
|
@mkschell - Hey Mike - not gonna block it ;-) Go for it on posting new issue... |
What does it do?
Increases the opacity of the drag-and-drop hint image in the Package Manager from the default (effectively ~0.1) to
0.25for the#modx-panel-packages.drag-n-drop::beforepseudo-element in_build/templates/default/sass/index.scss. The compiled CSS is produced bygrunt sassduring build; this PR only changes the SCSS source.Why is it needed?
With the previous opacity, the dragndrop.svg hint was barely visible and could be mistaken for a visual bug or artifact. Making the hint clearly visible (while still subtle) improves UX and matches the intent of the drag-and-drop zone.
How to test
Related issue(s)/PR(s)
Resolves #15989