fix(manager): scope trash and deleted counts to listable contexts#16938
Open
Ibochkarev wants to merge 2 commits intomodxcms:3.xfrom
Open
fix(manager): scope trash and deleted counts to listable contexts#16938Ibochkarev wants to merge 2 commits intomodxcms:3.xfrom
Ibochkarev wants to merge 2 commits intomodxcms:3.xfrom
Conversation
Add isContextListableByCurrentUser() and countDeletedResourcesInListableContexts() on modX. Use the same rule as the resource tree (context list policy) for trash processors, empty recycle bin, toolbar counter, purge/restore logging and flow. Includes PHPUnit coverage for the new helpers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
modX::isContextListableByCurrentUser(string $contextKey): boolandmodX::countDeletedResourcesInListableContexts(): int, aligned with the resource tree rule (context list policy viamodContext::checkPolicy('list')).Trash/GetList,Trash/Purge,Trash/Restore),EmptyRecycleBin, and the manager toolbar deleted-resource counter (GetToolbar).getContext()-only checks and removed TODOs in trash listing with the shared helper; tightens purge permission logging (save_ok/delete_ok).modXTestfor the new APIs and for consistency between the single-query counter and a per-context sum.Why is it needed?
Users who cannot list a context in the manager should not see deleted-resource counts, trash rows, or be able to purge/restore/empty the bin for resources in contexts they are not allowed to list—reducing information disclosure and keeping behavior consistent with the resource tree.
How to test
modXTest(or the project’s usual PHPUnit entry for_build/test).Related issue(s)/PR(s)
Resolves #13491