fix(3.x): Catch failure checking S3 file visibility#16940
Open
matdave wants to merge 2 commits intomodxcms:3.xfrom
Open
fix(3.x): Catch failure checking S3 file visibility#16940matdave wants to merge 2 commits intomodxcms:3.xfrom
matdave wants to merge 2 commits intomodxcms:3.xfrom
Conversation
| return $this->filesystem->visibility($path); | ||
| try { | ||
| return $this->filesystem->visibility($path); | ||
| } catch (\Exception | FilesystemException $exception) { |
Contributor
There was a problem hiding this comment.
Is there a reason why the \Exception is also a log level info? In my opinion this means something important is broken right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds a catch around the
$this->filesystem->visibilityfunction call in S3 media sources.Why is it needed?
Visibility can throw a
FilesystemExceptionexception if it is not implemented in the user's permissions. https://github.com/thephpleague/flysystem/blob/8aaffb653c5777781b0f7f69a5d937baf7ab6cdb/src/FilesystemAdapter.php#L68How to test
Ran into this on a site where the user did not have permissions to retrieve object metadata. However, I'm unsure how to replicate that.