Skip to content

chore: remove Woodpecker/Drone CI config files - #227

Merged
umangmoe merged 1 commit into
developmentfrom
chore/remove-ci-config-files
Jun 23, 2026
Merged

chore: remove Woodpecker/Drone CI config files#227
umangmoe merged 1 commit into
developmentfrom
chore/remove-ci-config-files

Conversation

@umangmoe

Copy link
Copy Markdown
Collaborator

Summary

Removes legacy CI configuration files that are no longer needed.

Files deleted:

  • .woodpecker.yml

Test plan

  • Verify no active CI pipelines depend on these files

@moe-hodor

moe-hodor Bot commented Jun 23, 2026

Copy link
Copy Markdown

🚪 Hodor is reviewing this PR... 👀

@moe-hodor moe-hodor Bot added branch:unknown Branch prefix did not match policy cfr:unknown Change Failure Rate: indeterminate labels Jun 23, 2026
@moe-hodor

moe-hodor Bot commented Jun 23, 2026

Copy link
Copy Markdown

⚠️ Branching Strategy — policy violation

Branch: chore/remove-ci-config-files — category: unknown, impact: ❓ Unknown CFR

Branching Strategy — unrecognized branch prefix

Branch chore/remove-ci-config-files doesn't use a recognized prefix. Per the Branching Strategy, use:

  • feature/ — planned work (neutral CFR)
  • patch/ — weekly maintenance (neutral CFR)
  • hotfix/ — emergency fix (⚠ increases CFR)
  • revert/ — rollback (⚠ increases CFR)

Posted by Hodor's branching-strategy gate. Per the Branching Strategy, branches must use feature/, patch/, hotfix/, or revert/ prefix. This comment is posted directly by the gate (not by the agent) to guarantee policy visibility.

@moe-hodor moe-hodor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Branching & CFR: chore/remove-ci-config-files — category: unknown, impact: ❓ Unknown CFR

⚠️ Branching Strategy — unrecognized branch prefix — Branch chore/remove-ci-config-files doesn't use a recognized prefix. Per the Branching Strategy, use:

  • feature/ — planned work (neutral CFR)
  • patch/ — weekly maintenance (neutral CFR)
  • hotfix/ — emergency fix (⚠ increases CFR)
  • revert/ — rollback (⚠ increases CFR)

This PR removes the legacy .woodpecker.yml CI configuration file. The repository has successfully migrated to GitHub Actions (.github/workflows/verify-pull-request.yml, release-plugins.yml, update_dependency.yml) which handles all build, test, and lint tasks.

Quality Gates

PR Size: 24 lines changed across 1 file — Good size.
Tests: Only config/docs changed — no tests needed.
Commits: All 1 commits follow Conventional Commits format.
Migrations: No migration files in this PR.
ℹ️ Config: 1 config file(s) modified.
Duplication: No obvious copy-paste patterns detected.

All checks passed.

Issues Found

  • ⚠️ 1 Warning — Secret scanning coverage gap
  • 💡 1 Suggestion — Branch naming convention

Key Concerns

⚠️ Secret Scanning Coverage: The removed Woodpecker CI config included a secret-checker pipeline step using moe-trufflehog to scan for exposed secrets/tokens. The current GitHub Actions workflows (.github/workflows/verify-pull-request.yml, release-plugins.yml, update_dependency.yml) do not appear to include equivalent secret scanning. This creates a security gap.

Recommendation: Consider adding a secret scanning step to the GitHub Actions workflow using GitHub's native secret scanning, Gitleaks action, or TruffleHog GitHub Action to maintain security coverage.

Regression Risk

No regression risk detected:

  • No references to .woodpecker.yml or Woodpecker CI found elsewhere in the codebase
  • GitHub Actions workflows are active and cover all CI needs (format, analyze, test, lint, build)
  • The DRONE_* environment variables in the removed file were only used within that file

What's Good

✅ Clean removal of legacy infrastructure
✅ GitHub Actions migration is complete and comprehensive
✅ No code dependencies on the removed file

Verdict

COMMENT — The removal is safe and appropriate. The only concern is ensuring secret scanning coverage is maintained through GitHub's security features or equivalent tooling in the existing GitHub Actions workflows. Consider addressing the branch naming convention per the MoEngage branching strategy.

@umangmoe
umangmoe merged commit bf96d90 into development Jun 23, 2026
6 checks passed
@umangmoe
umangmoe deleted the chore/remove-ci-config-files branch June 23, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch:unknown Branch prefix did not match policy cfr:unknown Change Failure Rate: indeterminate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant