chore: remove Woodpecker/Drone CI config files - #227
Conversation
|
🚪 Hodor is reviewing this PR... 👀 |
|
Branch: Branching Strategy — unrecognized branch prefix Branch
Posted by Hodor's branching-strategy gate. Per the Branching Strategy, branches must use |
There was a problem hiding this comment.
Review Summary
Branching & CFR: chore/remove-ci-config-files — category: unknown, impact: ❓ Unknown CFR
chore/remove-ci-config-files doesn't use a recognized prefix. Per the Branching Strategy, use:
feature/— planned work (neutral CFR)patch/— weekly maintenance (neutral CFR)hotfix/— emergency fix (⚠ increases CFR)revert/— rollback (⚠ increases CFR)
This PR removes the legacy .woodpecker.yml CI configuration file. The repository has successfully migrated to GitHub Actions (.github/workflows/verify-pull-request.yml, release-plugins.yml, update_dependency.yml) which handles all build, test, and lint tasks.
Quality Gates
✅ PR Size: 24 lines changed across 1 file — Good size.
✅ Tests: Only config/docs changed — no tests needed.
✅ Commits: All 1 commits follow Conventional Commits format.
✅ Migrations: No migration files in this PR.
ℹ️ Config: 1 config file(s) modified.
✅ Duplication: No obvious copy-paste patterns detected.
All checks passed. ✅
Issues Found
⚠️ 1 Warning — Secret scanning coverage gap- 💡 1 Suggestion — Branch naming convention
Key Concerns
secret-checker pipeline step using moe-trufflehog to scan for exposed secrets/tokens. The current GitHub Actions workflows (.github/workflows/verify-pull-request.yml, release-plugins.yml, update_dependency.yml) do not appear to include equivalent secret scanning. This creates a security gap.
Recommendation: Consider adding a secret scanning step to the GitHub Actions workflow using GitHub's native secret scanning, Gitleaks action, or TruffleHog GitHub Action to maintain security coverage.
Regression Risk
✅ No regression risk detected:
- No references to
.woodpecker.ymlor Woodpecker CI found elsewhere in the codebase - GitHub Actions workflows are active and cover all CI needs (format, analyze, test, lint, build)
- The DRONE_* environment variables in the removed file were only used within that file
What's Good
✅ Clean removal of legacy infrastructure
✅ GitHub Actions migration is complete and comprehensive
✅ No code dependencies on the removed file
Verdict
COMMENT — The removal is safe and appropriate. The only concern is ensuring secret scanning coverage is maintained through GitHub's security features or equivalent tooling in the existing GitHub Actions workflows. Consider addressing the branch naming convention per the MoEngage branching strategy.
Summary
Removes legacy CI configuration files that are no longer needed.
Files deleted:
Test plan