MOEN-44866: Downgrading Compile Java Version to 17 - #124
Conversation
|
🚪 Hodor is reviewing this PR... 👀 |
moe-hodor
Bot
added
branch:patch
![moe-hodor[bot]](https://avatars.githubusercontent.com/in/3251438?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review: MOEN-44866 Gradle Plugin Update (JVM 17 Downgrade)
Branching & CFR: patch/MOEN-44866_config_plugin_update — category: patch, impact: Neutral CFR ✅
Summary
This PR updates the com.moengage.android.hybrid.module.config.plugin Gradle plugin from 0.0.4 → 0.0.5 across all 6 React Native Android modules (core, cards, inbox, geofence, personalize, expo). The plugin update downgrades the compile JDK version from 21 to 17 for Java 17 compatibility.
Quality Gates
✅ PR Size: 46 lines across 12 files — good size
ℹ️ Tests: No test files modified (expected for build config change)
ℹ️ Commits: 1 commit
✅ Migrations: None
Jira Alignment
Ticket: MOEN-44866 — "Gradle config Plugin update JVM 17"
✅ Alignment: PR matches the ticket title. Ticket has no description or acceptance criteria to validate against.
Issues Found
✅ 0 Critical |
Key Observations
✅ What's Good:
- Consistent change: Plugin version updated in all 6 modules (cards, core, expo, geofence, inbox, personalize)
- CHANGELOG entries: Pre-release entries added to all affected modules with consistent formatting
- Clean patch branch: Named correctly (
patch/MOEN-44866_...) for a compatibility fix - Verified plugin source: The plugin is maintained in
moengage/gradle-config-plugin, and version 0.0.5 explicitly downgrades JDK from 21→17 - Cosmetic cleanup: Removed trailing whitespace in
inbox/android/build.gradle:58
Cross-org search shows moengage/Flutter-SDK still uses plugin version 0.0.4 in 5 modules. Flutter developers will need the same Java 17 downgrade for consistency. Consider opening a companion PR or Jira ticket for Flutter SDK.
📋 Changelog Format:
The pre-release placeholder format (# Release Date, ## Release Version) is intentional — these will be replaced with actual dates/versions at release time. This is consistent with the repo's changelog pattern.
Regression Risk
Low. This is a build-time plugin version bump:
- Only affects Gradle build configuration (JVM target version)
- No runtime code changes
- No API surface changes
- Plugin already deployed and tested in
gradle-config-pluginrepo - Change is backwards-compatible (downgrading JVM target is safer than upgrading)
Recommendations
- Coordinate Flutter SDK update — File a ticket or PR to update Flutter SDK to plugin
0.0.5for consistency - Validate sample apps build — Ensure
SampleApp,ExpoSampleApp, andExpoTVSampleAppall build successfully with JVM 17 - Test on CI — Verify all Android builds pass with the new plugin version across all 6 modules
Verdict
✅ LGTM with minor note — This is a clean, well-structured plugin version bump for Java 17 compatibility. The only action item is syncing the Flutter SDK to the same plugin version for cross-platform consistency.
Hodor holds the gate. This code may pass. The plugin update is sound. ✅
2 participants
Jira Ticket
https://moengagetrial.atlassian.net/browse/MOEN-44866
Description
Downgrading Compile Java Version to 17