Skip to content

chore: remove Woodpecker/Drone CI config files - #126

Merged
umangmoe merged 2 commits into
developmentfrom
chore/remove-ci-config-files
Jun 23, 2026
Merged

chore: remove Woodpecker/Drone CI config files#126
umangmoe merged 2 commits into
developmentfrom
chore/remove-ci-config-files

Conversation

@umangmoe

Copy link
Copy Markdown
Collaborator

Summary

Removes legacy CI configuration files that are no longer needed.

Files deleted:

  • .woodpecker.yml
  • .drone.yml

Test plan

  • Verify no active CI pipelines depend on these files

@moe-hodor

moe-hodor Bot commented Jun 23, 2026

Copy link
Copy Markdown

🚪 Hodor is reviewing this PR... 👀

@moe-hodor moe-hodor Bot added branch:unknown Branch prefix did not match policy cfr:unknown Change Failure Rate: indeterminate labels Jun 23, 2026
@moe-hodor

moe-hodor Bot commented Jun 23, 2026

Copy link
Copy Markdown

⚠️ Branching Strategy — policy violation

Branch: chore/remove-ci-config-files — category: unknown, impact: ❓ Unknown CFR

Branching Strategy — unrecognized branch prefix

Branch chore/remove-ci-config-files doesn't use a recognized prefix. Per the Branching Strategy, use:

  • feature/ — planned work (neutral CFR)
  • patch/ — weekly maintenance (neutral CFR)
  • hotfix/ — emergency fix (⚠ increases CFR)
  • revert/ — rollback (⚠ increases CFR)

Posted by Hodor's branching-strategy gate. Per the Branching Strategy, branches must use feature/, patch/, hotfix/, or revert/ prefix. This comment is posted directly by the gate (not by the agent) to guarantee policy visibility.

Comment thread .drone.yml

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Suggestion — Verify secret scanning replacement: This Drone config ran moe-trufflehog to detect hardcoded secrets on every PR. Confirm that GitHub Actions (or GitHub Advanced Security's secret scanning) has replaced this security gate. If not, secrets could slip through. Check if .github/workflows/pull_request_verification.yml includes a secret scanning step or if GitHub's built-in secret scanning is enabled for this repo.

@moe-hodor moe-hodor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hodor's Review: CI Config Cleanup

Branching & CFR: chore/remove-ci-config-files — category: unknown, impact: ❓ Unknown CFR

⚠️ Branching Strategy — unrecognized branch prefix — Branch chore/remove-ci-config-files doesn't use a recognized prefix. Per the Branching Strategy, use:

  • feature/ — planned work (neutral CFR)
  • patch/ — weekly maintenance (neutral CFR)
  • hotfix/ — emergency fix (⚠ increases CFR)
  • revert/ — rollback (⚠ increases CFR)

Summary

This PR removes legacy Drone CI (.drone.yml) and Woodpecker CI (.woodpecker.yml) configuration files. Both files configured secret scanning via trufflehog and Slack notifications on failure.

Quality Gates

PR Size: 48 lines changed across 2 files — Good size.
Tests: Only config files deleted — no tests needed.
Commits: All 2 commits follow Conventional Commits format.
Migrations: No migration files in this PR.
Config: 2 config files deleted.
Duplication: No duplication detected.

All checks passed.

Issues Found

  • 🔴 Critical: 0
  • ⚠️ Warning: 1 (branching prefix)
  • 💡 Suggestion: 1

Key Concerns

1. Migration Path Verification

The PR deletes Drone/Woodpecker CI configs. I verified that:

  • GitHub Actions is already in place: .github/workflows/pull_request_verification.yml handles PR verification (iOS, React, Android builds)
  • No code references found: No other files in the repo reference .drone.yml or .woodpecker.yml
  • ⚠️ Secret scanning replacement: The deleted configs ran trufflehog for secret detection on every PR. Need to confirm GitHub Actions or another tool has replaced this security gate.

2. Test Plan Checkbox

The PR description includes:

- [ ] Verify no active CI pipelines depend on these files

This checkbox is unchecked. Before merging, confirm that Drone/Woodpecker CI runners are no longer monitoring this repo.

Regression Risk

Low. The repo already has a complete GitHub Actions workflow in place. The only potential gap is secret scanning (trufflehog), which these legacy configs provided.

What's Good

  • Clean removal of legacy infrastructure
  • GitHub Actions is already the active CI system
  • No code dependencies on these files

Verdict

Safe to merge once the test plan is verified and secret scanning coverage is confirmed.

The code change itself is clean — just deleting unused CI configs. The only action item is confirming the migration is complete (old CI systems deactivated, secret scanning replaced).

@umangmoe
umangmoe merged commit 1ca4bf8 into development Jun 23, 2026
7 of 9 checks passed
@umangmoe
umangmoe deleted the chore/remove-ci-config-files branch June 23, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch:unknown Branch prefix did not match policy cfr:unknown Change Failure Rate: indeterminate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant