chore: remove Woodpecker/Drone CI config files - #126
Conversation
|
🚪 Hodor is reviewing this PR... 👀 |
|
Branch: Branching Strategy — unrecognized branch prefix Branch
Posted by Hodor's branching-strategy gate. Per the Branching Strategy, branches must use |
There was a problem hiding this comment.
💡 Suggestion — Verify secret scanning replacement: This Drone config ran moe-trufflehog to detect hardcoded secrets on every PR. Confirm that GitHub Actions (or GitHub Advanced Security's secret scanning) has replaced this security gate. If not, secrets could slip through. Check if .github/workflows/pull_request_verification.yml includes a secret scanning step or if GitHub's built-in secret scanning is enabled for this repo.
There was a problem hiding this comment.
Hodor's Review: CI Config Cleanup
Branching & CFR: chore/remove-ci-config-files — category: unknown, impact: ❓ Unknown CFR
chore/remove-ci-config-files doesn't use a recognized prefix. Per the Branching Strategy, use:
feature/— planned work (neutral CFR)patch/— weekly maintenance (neutral CFR)hotfix/— emergency fix (⚠ increases CFR)revert/— rollback (⚠ increases CFR)
Summary
This PR removes legacy Drone CI (.drone.yml) and Woodpecker CI (.woodpecker.yml) configuration files. Both files configured secret scanning via trufflehog and Slack notifications on failure.
Quality Gates
✅ PR Size: 48 lines changed across 2 files — Good size.
✅ Tests: Only config files deleted — no tests needed.
✅ Commits: All 2 commits follow Conventional Commits format.
✅ Migrations: No migration files in this PR.
✅ Config: 2 config files deleted.
✅ Duplication: No duplication detected.
All checks passed. ✅
Issues Found
- 🔴 Critical: 0
⚠️ Warning: 1 (branching prefix)- 💡 Suggestion: 1
Key Concerns
1. Migration Path Verification
The PR deletes Drone/Woodpecker CI configs. I verified that:
- ✅ GitHub Actions is already in place:
.github/workflows/pull_request_verification.ymlhandles PR verification (iOS, React, Android builds) - ✅ No code references found: No other files in the repo reference
.drone.ymlor.woodpecker.yml ⚠️ Secret scanning replacement: The deleted configs ran trufflehog for secret detection on every PR. Need to confirm GitHub Actions or another tool has replaced this security gate.
2. Test Plan Checkbox
The PR description includes:
- [ ] Verify no active CI pipelines depend on these files
This checkbox is unchecked. Before merging, confirm that Drone/Woodpecker CI runners are no longer monitoring this repo.
Regression Risk
Low. The repo already has a complete GitHub Actions workflow in place. The only potential gap is secret scanning (trufflehog), which these legacy configs provided.
What's Good
- Clean removal of legacy infrastructure
- GitHub Actions is already the active CI system
- No code dependencies on these files
Verdict
✅ Safe to merge once the test plan is verified and secret scanning coverage is confirmed.
The code change itself is clean — just deleting unused CI configs. The only action item is confirming the migration is complete (old CI systems deactivated, secret scanning replaced).
Summary
Removes legacy CI configuration files that are no longer needed.
Files deleted:
Test plan