Skip to content

MOEN-45786: Dependency Update 2026-07-01 - #127

Closed
sdk-bot-user wants to merge 1 commit into
developmentfrom
MOEN-45786/dependency_update
Closed

MOEN-45786: Dependency Update 2026-07-01#127
sdk-bot-user wants to merge 1 commit into
developmentfrom
MOEN-45786/dependency_update

Conversation

@sdk-bot-user

Copy link
Copy Markdown
Collaborator

Summary

Automated dependency update (target: both).

Platform status

  • Android: success
  • iOS: success

@moe-hodor

moe-hodor Bot commented Jul 1, 2026

Copy link
Copy Markdown

🚪 Hodor is reviewing this PR... 👀

@moe-hodor moe-hodor Bot added branch:unknown Branch prefix did not match policy cfr:unknown Change Failure Rate: indeterminate labels Jul 1, 2026
@moe-hodor

moe-hodor Bot commented Jul 1, 2026

Copy link
Copy Markdown

⚠️ Branching Strategy — policy violation

Branch: MOEN-45786/dependency_update — category: unknown, impact: ❓ Unknown CFR

Branching Strategy — unrecognized branch prefix

Branch MOEN-45786/dependency_update doesn't use a recognized prefix. Per the Branching Strategy, use:

  • feature/ — planned work (neutral CFR)
  • patch/ — weekly maintenance (neutral CFR)
  • hotfix/ — emergency fix (⚠ increases CFR)
  • revert/ — rollback (⚠ increases CFR)

Posted by Hodor's branching-strategy gate. Per the Branching Strategy, branches must use feature/, patch/, hotfix/, or revert/ prefix. This comment is posted directly by the gate (not by the agent) to guarantee policy visibility.

@@ -2,7 +2,7 @@ import com.moengage.gradle.android.library.plugin.configs.BuildConfigType

ext {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Critical — Version inconsistency: moengageNativeBOMVersion is still "2.2.1" while all other modules (cards, core, geofence, personalize) were updated to "2.3.0" in this PR. This creates a multi-version state where the inbox module depends on Android BOM 2.2.1 but other modules depend on 2.3.0.

Impact: Runtime ClassLoader conflicts when inbox and other modules interact via shared moe-android-sdk classes. Gradle may silently resolve to one version, masking the issue until production.

Fix: Update this line to moengageNativeBOMVersion = "2.3.0" to match the other modules.

ext {
moengageNativeBOMVersion = "2.2.2"
moengageNativeBOMVersion = "2.3.0"
moengagePluginBaseBOMVersion = "3.0.1"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Warning — Plugin BOM version lag: moengagePluginBaseBOMVersion is still "3.0.1" while cards, core, and inbox were all updated to "3.1.0" in this PR. Geofence is now one minor version behind the other modules.

Possible reasons:

  • Intentional (geofence has compatibility constraints with 3.0.x)
  • Oversight in the automated update script

The CHANGELOG for geofence only mentions the android-bom update to 2.3.0, but doesn't mention plugin-base-bom staying at 3.0.1.

Recommendation: Verify whether this is intentional. If not, update to "3.1.0" for consistency.

@moe-hodor moe-hodor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: MOEN-45786 Dependency Update

Issues (2 after filtering):
🔴 Critical: 1
⚠️ Warning: 1

Hodor filtered 1 low-signal comment(s) to reduce noise.
Verdict: REQUEST_CHANGES

@umangmoe umangmoe closed this Jul 1, 2026
@umangmoe
umangmoe deleted the MOEN-45786/dependency_update branch July 1, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch:unknown Branch prefix did not match policy cfr:unknown Change Failure Rate: indeterminate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants