MOEN-45786: Fix changelog in dependency update - #129
Conversation
|
🚪 Hodor is reviewing this PR... 👀 |
|
Branch: Branching Strategy — unrecognized branch prefix Branch
Posted by Hodor's branching-strategy gate. Per the Branching Strategy, branches must use |
| @@ -1,3 +1,13 @@ | |||
| # Release Date | |||
There was a problem hiding this comment.
🔴 Critical — Incomplete CHANGELOG entry: The header # Release Date is a placeholder. This must be replaced with the actual release date (e.g., # 01-15-2025) before merging. The same applies to line 3 (## Release Version should be the actual version number like ## 12.9.0).
Impact: Without actual dates and versions, the changelog is unusable for customers and internal tracking. This breaks release documentation standards.
Fix: Replace placeholders with real values:
# 01-15-2025
## 12.9.0This issue appears in all 5 CHANGELOG files (core, cards, inbox, geofence, personalize).
| working-directory: source | ||
| run: | | ||
| .github/scripts/release.main.kts ${{ github.event.inputs.releaseNotes }} ${{ github.event.inputs.releaseTicket }} | ||
| kotlin .github/scripts/release.main.kts ${{ github.event.inputs.releaseNotes }} ${{ github.event.inputs.releaseTicket }} |
There was a problem hiding this comment.
kotlin .github/scripts/release.main.kts, but line 47 in the same workflow uses direct shebang execution .github/scripts/release.main.kts after chmod +x.
Inconsistency:
- Line 47:
.github/scripts/release.main.kts(direct execution via shebang) - Line 50 (this change):
kotlin .github/scripts/release.main.kts(explicit interpreter) - Line 54:
kotlin .github/scripts/notify-release.main.kts(explicit interpreter)
Impact: Mixed execution methods create maintenance confusion. If the shebang approach works, use it everywhere. If explicit kotlin is preferred, update line 47 too.
Recommendation: For consistency, either:
- Change line 47 to
kotlin .github/scripts/release.main.kts(matches lines 50, 54) - Or revert line 50 to
.github/scripts/release.main.kts(matches line 47)
Option 1 is recommended since explicit interpreter invocation is clearer in CI logs.
| @@ -1,3 +1,12 @@ | |||
| # Release Date | |||
There was a problem hiding this comment.
🔴 Critical — Same issue as core/CHANGELOG.md: Replace placeholder # Release Date with actual date and ## Release Version with actual version number before merge.
See detailed explanation in the comment on sdk/core/CHANGELOG.md:1.
(Same concern also applies to sdk/inbox/CHANGELOG.md:1, sdk/geofence/CHANGELOG.md:1, sdk/personalize/CHANGELOG.md:1)
eb59f7f to
0447c53
Compare
Jira Ticket
Description
Fix in change log