Skip to content

MOEN-45786: Fix changelog in dependency update - #129

Merged
umangmoe merged 4 commits into
developmentfrom
MOEN-45786/dependency_update_changelog
Jul 2, 2026
Merged

MOEN-45786: Fix changelog in dependency update #129
umangmoe merged 4 commits into
developmentfrom
MOEN-45786/dependency_update_changelog

Conversation

@AnirudhaSM-engg-sdk

Copy link
Copy Markdown
Contributor

Jira Ticket

Description

Fix in change log

@moe-hodor

moe-hodor Bot commented Jul 2, 2026

Copy link
Copy Markdown

🚪 Hodor is reviewing this PR... 👀

@moe-hodor moe-hodor Bot added branch:unknown Branch prefix did not match policy cfr:unknown Change Failure Rate: indeterminate labels Jul 2, 2026
@moe-hodor

moe-hodor Bot commented Jul 2, 2026

Copy link
Copy Markdown

⚠️ Branching Strategy — policy violation

Branch: MOEN-45786/dependency_update_changelog — category: unknown, impact: ❓ Unknown CFR

Branching Strategy — unrecognized branch prefix

Branch MOEN-45786/dependency_update_changelog doesn't use a recognized prefix. Per the Branching Strategy, use:

  • feature/ — planned work (neutral CFR)
  • patch/ — weekly maintenance (neutral CFR)
  • hotfix/ — emergency fix (⚠ increases CFR)
  • revert/ — rollback (⚠ increases CFR)

Posted by Hodor's branching-strategy gate. Per the Branching Strategy, branches must use feature/, patch/, hotfix/, or revert/ prefix. This comment is posted directly by the gate (not by the agent) to guarantee policy visibility.

Comment thread sdk/core/CHANGELOG.md
@@ -1,3 +1,13 @@
# Release Date

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Critical — Incomplete CHANGELOG entry: The header # Release Date is a placeholder. This must be replaced with the actual release date (e.g., # 01-15-2025) before merging. The same applies to line 3 (## Release Version should be the actual version number like ## 12.9.0).

Impact: Without actual dates and versions, the changelog is unusable for customers and internal tracking. This breaks release documentation standards.

Fix: Replace placeholders with real values:

# 01-15-2025

## 12.9.0

This issue appears in all 5 CHANGELOG files (core, cards, inbox, geofence, personalize).

working-directory: source
run: |
.github/scripts/release.main.kts ${{ github.event.inputs.releaseNotes }} ${{ github.event.inputs.releaseTicket }}
kotlin .github/scripts/release.main.kts ${{ github.event.inputs.releaseNotes }} ${{ github.event.inputs.releaseTicket }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Warning — Inconsistent script execution within workflow: This line now uses kotlin .github/scripts/release.main.kts, but line 47 in the same workflow uses direct shebang execution .github/scripts/release.main.kts after chmod +x.

Inconsistency:

  • Line 47: .github/scripts/release.main.kts (direct execution via shebang)
  • Line 50 (this change): kotlin .github/scripts/release.main.kts (explicit interpreter)
  • Line 54: kotlin .github/scripts/notify-release.main.kts (explicit interpreter)

Impact: Mixed execution methods create maintenance confusion. If the shebang approach works, use it everywhere. If explicit kotlin is preferred, update line 47 too.

Recommendation: For consistency, either:

  1. Change line 47 to kotlin .github/scripts/release.main.kts (matches lines 50, 54)
  2. Or revert line 50 to .github/scripts/release.main.kts (matches line 47)

Option 1 is recommended since explicit interpreter invocation is clearer in CI logs.

Comment thread sdk/cards/CHANGELOG.md
@@ -1,3 +1,12 @@
# Release Date

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Critical — Same issue as core/CHANGELOG.md: Replace placeholder # Release Date with actual date and ## Release Version with actual version number before merge.

See detailed explanation in the comment on sdk/core/CHANGELOG.md:1.

(Same concern also applies to sdk/inbox/CHANGELOG.md:1, sdk/geofence/CHANGELOG.md:1, sdk/personalize/CHANGELOG.md:1)

@moe-hodor moe-hodor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: MOEN-45786 Dependency Update Changelog Fix

Issues (3 after filtering):
🔴 Critical: 2
⚠️ Warning: 1

Hodor filtered 6 low-signal comment(s) to reduce noise.
Verdict: COMMENT

@AnirudhaSM-engg-sdk
AnirudhaSM-engg-sdk force-pushed the MOEN-45786/dependency_update_changelog branch from eb59f7f to 0447c53 Compare July 2, 2026 06:41
@umangmoe
umangmoe merged commit 37e1f83 into development Jul 2, 2026
9 checks passed
@umangmoe
umangmoe deleted the MOEN-45786/dependency_update_changelog branch July 2, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch:unknown Branch prefix did not match policy cfr:unknown Change Failure Rate: indeterminate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants