MOEN-46338: Adopt SDK 11 @MainActor @Sendable cards handler signatures - #6
Open
AnirudhaSM-engg-sdk wants to merge 1 commit into
Open
MOEN-46338: Adopt SDK 11 @MainActor @Sendable cards handler signatures#6AnirudhaSM-engg-sdk wants to merge 1 commit into
AnirudhaSM-engg-sdk wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#Jira
https://moengagetrial.atlassian.net/browse/MOEN-46340
Changes
MoEngageCards 6.0.0 made all
MoEngageSDKCardscompletion closures@MainActor @Sendable. This updates theMoEngagePluginCardsBridgeHandlerprotocol (12 completion closures) + the test mock to match, restoring the emptyextension MoEngageSDKCards: MoEngagePluginCardsBridgeHandler {}conformance.Verification
Note — depends on the SDK-11 PluginBase release
CI on this PR stays red until PluginBase publishes with SDK-11 support (cards resolves the published PluginBase). The dependency pin bumps + CHANGELOG dependency lines (
Updated MoEngage-iOS-SDK/Updated MoEngagePluginBase) are release-generated via therelease_dependentscascade — not hand-committed here.