nix: rename can -> python-can, removed unused canopen#41
Open
thefloweringash wants to merge 1 commit intomainfrom
Open
nix: rename can -> python-can, removed unused canopen#41thefloweringash wants to merge 1 commit intomainfrom
thefloweringash wants to merge 1 commit intomainfrom
Conversation
canopen was accidentally an alias of python-can (née can), and had no effect on the build.
MattSturgeon
approved these changes
Mar 19, 2026
| # from zephyr/scripts/requirements-base.txt | ||
| packageOverrides = pyself: pysuper: { | ||
| can = pysuper.can.overrideAttrs (_: { | ||
| python-can = pysuper.python-can.overrideAttrs (_: { |
There was a problem hiding this comment.
This is needed in order to bump nixpkgs, as the old can alias has been removed. 👍
Comment on lines
21
to
22
| doCheck = false; | ||
| doInstallCheck = false; |
There was a problem hiding this comment.
It'd be great to upstream this (or disable relevant tests in nixpkgs), as nixpkgs also doesn't want flaky packages.
That'd mean you no longer need an overridden python scope.
Out-of-scope for this PR, I'm just noting for the record.
antoineco
added a commit
to antoineco/dotfiles
that referenced
this pull request
Apr 22, 2026
Commit 10ab730 accidentally broke the Glove80 build, because the 'can' alias for 'python-can' no longer exists[1] in the updated nixpkgs revision. [1]: moergo-sc/zmk#41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR check-list