Skip to content

Fix issues in FeedService handling and syntax #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moeux merged 3 commits into from
Mar 7, 2026
Merged

Fix issues in FeedService handling and syntax #4

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17351d4
fix(feed-service): handle null ImageUrl in author icon url
moeux Mar 7, 2026
41f1eff
fix(feed-service): handle large embed chunks and cancellation tokens
moeux Mar 7, 2026
57acf7d
fix(feed-service): add missing closing brace in FeedService
moeux Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions Courier/Services/FeedService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ private async Task SendMessageAsync(
embedBuilder
.WithAuthor(authorBuilder => authorBuilder
.WithName(feed.Title.Text.ToMarkdown().Truncate(EmbedAuthorBuilder.MaxAuthorNameLength))
.WithIconUrl(feed.ImageUrl.ToString()))
.WithIconUrl(feed.ImageUrl?.ToString()))
.WithFooter(feed.Description.Text.ToMarkdown().Truncate(EmbedFooterBuilder.MaxFooterTextLength))
.WithUrl(item.Links.Count != 0 ? item.Links.First().Uri.ToString() : item.Id)
.WithTitle(item.Title.Text.ToMarkdown().Truncate(EmbedBuilder.MaxTitleLength))
Expand All @@ -162,12 +162,29 @@ private async Task SendMessageAsync(
embeds.Add(embedBuilder.Build());
}

foreach (var embedArray in embeds.Chunk(DiscordConfig.MaxEmbedsPerMessage))
await textChannel.SendMessageAsync(embeds: embedArray, options: new RequestOptions
foreach (var chunk in embeds.Chunk(DiscordConfig.MaxEmbedsPerMessage))
{
if (cancellationToken.IsCancellationRequested) break;

if (chunk.Sum(embed => embed.Length) > EmbedBuilder.MaxEmbedLength)
{
foreach (var embed in chunk)
await textChannel.SendMessageAsync(embed: embed, options: new RequestOptions
{
Timeout = DiscordConfig.DefaultRequestTimeout,
CancelToken = cancellationToken,
RetryMode = RetryMode.AlwaysRetry
});

continue;
}

await textChannel.SendMessageAsync(embeds: chunk, options: new RequestOptions
{
Timeout = DiscordConfig.DefaultRequestTimeout,
CancelToken = cancellationToken,
RetryMode = RetryMode.AlwaysRetry
});
}
}
}