Skip to content

[deploy] 배포 #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jun3671 merged 1 commit into from
Sep 19, 2026
Merged

[deploy] 배포 #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/main/java/com/moive/MoiveBE/domain/vote/controller/VoteController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import com.moive.MoiveBE.domain.vote.dto.DateVoteResultResponse;
import com.moive.MoiveBE.domain.vote.dto.PlaceVoteRequest;
import com.moive.MoiveBE.domain.vote.dto.PlaceVoteResponse;
import com.moive.MoiveBE.domain.vote.dto.PlaceVoteResultResponse;
import com.moive.MoiveBE.domain.vote.service.VoteService;
import com.moive.MoiveBE.global.common.BaseResponse;
Expand Down Expand Up @@ -43,13 +42,13 @@ public BaseResponse<DateVoteResultResponse> getMeetingScheduleVoteResult (
description = "추천 장소들에 대한 투표를 진행합니다."
)
@PostMapping("/place-votes")
public BaseResponse<PlaceVoteResponse> createMeetingPlaceVote (
public BaseResponse<Void> createMeetingPlaceVote (
@AuthenticationPrincipal Long userId,
@PathVariable Long meetingId,
@Valid @RequestBody PlaceVoteRequest request
) {
boolean isConfirmed = voteService.createPlaceVote(userId, meetingId, request);
return BaseResponse.success(PlaceVoteResponse.of(isConfirmed));
voteService.createPlaceVote(userId, meetingId, request);
return BaseResponse.success(null);
}

@Operation(
Expand Down
6 changes: 2 additions & 4 deletions src/main/java/com/moive/MoiveBE/domain/vote/service/VoteService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ private DateVoteResultResponse.Candidate toCandidate(DateVoteSummary aggregate)
* 장소 투표 생성
*/
@Transactional
public boolean createPlaceVote(Long userId, Long meetingId, PlaceVoteRequest request) {
public void createPlaceVote(Long userId, Long meetingId, PlaceVoteRequest request) {
// 모임 조회
Meeting meeting = meetingRepository.findById(meetingId)
.orElseThrow(() -> new CustomException(MEETING_NOT_FOUND));
Expand Down Expand Up @@ -219,11 +219,9 @@ public boolean createPlaceVote(Long userId, Long meetingId, PlaceVoteRequest req
long voterCnt = placeVoteRepository.countDistinctVoters(meetingId);
long eligibleCnt = participantRepository.countByMeetingIdAndLeftAtIsNullAndStateNot(
meetingId, ParticipantState.NEW_RESTRICTED);
boolean isConfirmed = voterCnt == eligibleCnt;
if (isConfirmed) {
if (voterCnt == eligibleCnt) {
confirmMeetingPlace(meeting);
}
return isConfirmed;
}

// 모임 장소 확정
Expand Down
Loading