Refactor LocalDomainError and SimulationError for improved exception handling.#92
Draft
SlipperyGnome wants to merge 3 commits intomoja-global:developfrom
Draft
Refactor LocalDomainError and SimulationError for improved exception handling.#92SlipperyGnome wants to merge 3 commits intomoja-global:developfrom
SlipperyGnome wants to merge 3 commits intomoja-global:developfrom
Conversation
Contributor
|
@RobboW - is there anyone on your team available to review @SlipperyGnome's changes? If acceptable, it'd be great to understand where else the templated exception function can be used and what a complete PR should contain. |
|
Let me check.
|
Signed-off-by: Debolina Ghatuary <debolinaghatuary200011@gmail.com>
Signed-off-by: Debolina Ghatuary <debolinaghatuary200011@gmail.com>
aornugent
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is for the issue #48
The catch blocks for SimulationError and LocalDomainError in this file had messy and repetitive codes which are now defined in one function _handleFLINTException. This change is done only for one set of try/catch blocks for now.
Signed-off-by: Debolina Ghatuary debolinaghatuary200011@gmail.com