Made 2D column attributes add correctly to the combined object. Also …#18
Open
lambdamoses wants to merge 6 commits intomojaveazure:developfrom
Open
Made 2D column attributes add correctly to the combined object. Also …#18lambdamoses wants to merge 6 commits intomojaveazure:developfrom
lambdamoses wants to merge 6 commits intomojaveazure:developfrom
Conversation
…fixed progress bar in case there're multiple matches to a string pattern.
…ion to use matrix with genes as columns and cells as rows, in order not to transpose large matrices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…fixed progress bar in case there're multiple matches to a string pattern.
I have been working with loom objects with Seurat recently. From Seurat, the PCA cell embeddings and tSNE cell embeddings are 2 dimensional. I found that the development version of loomR doesn't play nicely with 2D column attributes when combining loom objects. For instance, the number of rows in 2D column attributes are doubled. So I made these modifications, and so far they work for me.