Skip to content

Fix a11y bugs #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fymmot merged 2 commits into from
May 13, 2025
Merged

Fix a11y bugs #71

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66bbde1
Fix bug where keyboard mode would not immediately trigger, plus small…
fymmot May 13, 2025
305b934
Update size of the visibility box to identify more countries
fymmot May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions src/assets/js/keyboard-mode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,8 @@ function isInViewport(element) {
const rect = element.getBoundingClientRect();

// Define the dimensions of the rectangle
const rectangleWidth = 400;
const rectangleHeight = 400;
const rectangleWidth = 500;
const rectangleHeight = 500;

// Calculate the position of the rectangle
const rectangleLeft = (window.innerWidth - rectangleWidth) / 2;
Expand Down Expand Up @@ -413,10 +413,9 @@ function updateVisibleCountries(zoom) {
// Lets start keyboard mode
KEYBOARD_MODE_ACTIVE = true;
displayKeyboardModeMessage();

// TODO: Find a working way to only announce this once
if (!hasAnnounced) {
announcer.announce("Keyboard mode active! Press L to hear the list of countries. Press A to turn on audio feedback.")
announcer.announce("Keyboard mode active! Press L to hear the list of countries.")
hasAnnounced = true;
}

Expand Down Expand Up @@ -505,10 +504,8 @@ function assignNumbersToCountries() {
// Update the announcement functions to only include country count when keyboard mode is active
function getAnnouncementText(baseText) {
if (KEYBOARD_MODE_ACTIVE) {
const audioFeedbackState = window.auditoryFeedback && window.auditoryFeedback.isEnabled()
? "turn off"
: "turn on";
return `${baseText}. ${getVisibleCountriesSummary()}. Press A to ${audioFeedbackState} audio feedback.`;
const audioFeedbackIsEnabled = window.auditoryFeedback && window.auditoryFeedback.isEnabled();
return `${baseText}. ${getVisibleCountriesSummary()}. ${audioFeedbackIsEnabled ? "Press A to turn off audio feedback." : ""}`;
}
return baseText;
}
Expand Down Expand Up @@ -668,7 +665,9 @@ function getAnnouncementText(baseText) {
e.preventDefault();
move(t, s, false, true);

getVisibleCountries();
// Update visible countries and keyboard mode
updateVisibleCountries(zoom);

// Update announcement to include country count only when keyboard mode is active
setTimeout(() => {
const baseMessage = `Zoom ${e.key === '+' ? "in" : "out"} level ${parseInt(newScale)}`;
Expand Down