fix close button assignment not working on artifical click event#77
Open
GoldenKoopa wants to merge 1 commit intomold:masterfrom
Open
fix close button assignment not working on artifical click event#77GoldenKoopa wants to merge 1 commit intomold:masterfrom
GoldenKoopa wants to merge 1 commit intomold:masterfrom
Conversation
Author
|
accidentally pushed wrong changes, should now be correct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when selecting the country from the country list, the click event is artificially created
therefore there is no mouse position and d3.mouse(svg.node()) throws errors which causes the close button to not get assigned its closing function
this is fixed by only calling it if there is a mouse position and otherwise assigning values ([0, 0])