test: make release version fixtures version-agnostic - #392
Merged
Merged
Conversation
35 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.6.0assumption that makes ordinary CI fail immediately after a release bumpCause
The guarded release flow runs these tests before updating manifests. They passed while the workspace was still
0.6.0, but the release commit changed the copied fixtures to0.6.1while the test continued invoking the checker withv0.6.0.Validation
bash scripts/tests/release-version.test.sh— 5/5 passednpm run test:scripts— passedbash scripts/check-release-version.sh v0.6.1— passedbash -n scripts/tests/release-version.test.shgit diff --checkTest-only change; no runtime, transport, adapter, or package behavior is modified.