Skip to content

fix(adapter): align response body limit with core - #395

Merged
momics merged 4 commits into
mainfrom
momics-fix-adapter-config-limits
Aug 28, 2026
Merged

momics merged 4 commits into
mainfrom
momics-fix-adapter-config-limits

Conversation

@momics

@momics momics commented Aug 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • accept explicit maxResponseBodyBytes values through the core's 256 MiB default while retaining the independent 16 MiB request-body bounds
  • source adapter request/response limits from exported core constants to prevent policy drift
  • preserve and classify terminal response-stream errors so BODY_TOO_LARGE is not replaced by a generic or invalid-handle failure
  • document the accepted range and add shared Node/Deno/Tauri conformance coverage

Validation

  • cargo test -p iroh-http-core -p iroh-http-adapter
  • npm run typecheck
  • Node and Deno shared adapter-validation suites
  • Node and Deno adapter/compliance suites
  • Tauri Rust and guest-JS suites

Full npm run ci reaches an unrelated existing cargo deny failure for RUSTSEC-2026-0258 (h2 0.4.15; patched in 0.4.16).

Closes #394

momics and others added 4 commits August 27, 2026 15:56
Reproduces the 16 MiB adapter ceiling despite the core's 256 MiB response default across the shared adapter conformance path.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Source adapter body bounds from the core defaults so explicit response limits up to 256 MiB are accepted while request limits remain capped at 16 MiB. Preserve structured terminal stream errors instead of retrying hard failures as transient empty reads.

Closes #394

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Update h2 to the release fixing RUSTSEC-2026-0258 and replace the newly yanked chacha20 0.10.1 release so the dependency policy gate can complete.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Refresh compatible transitive dependencies for newly published js-yaml, nanoid, postcss, and undici advisories so the npm audit gate passes.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@momics
momics merged commit 7330a82 into main Aug 28, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapter rejects maxResponseBodyBytes above 16 MiB despite 256 MiB core response default

1 participant