Skip to content

fix: fall back to viewBox when SVG logo lacks width/height #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamvukasin merged 1 commit into from
Sep 15, 2026
Merged

fix: fall back to viewBox when SVG logo lacks width/height #184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions scripts/validate_tokens.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,9 @@ def validate_cross_chain_metadata(
def get_svg_dimensions(svg_path: Path) -> tuple[int | None, int | None]:
"""Extract width and height from an SVG file.

Falls back to the viewBox attribute when width/height are absent, since
SVGs exported without explicit pixel dimensions are common and valid.

Args:
svg_path: Path to the SVG file.

Expand All @@ -370,6 +373,14 @@ def get_svg_dimensions(svg_path: Path) -> tuple[int | None, int | None]:
height = int(re.sub(r"[^0-9.]", "", height_str).split(".")[0])
return width, height

view_box = root.get("viewBox")
if view_box:
parts = view_box.replace(",", " ").split()
if len(parts) == 4:
width = int(float(parts[2]))
height = int(float(parts[3]))
return width, height

return None, None
except Exception:
return None, None
Expand Down
Loading