This repository was archived by the owner on May 14, 2026. It is now read-only.
Reload services after server CRUD so creds aren't stale - #24
Merged
Merged
Conversation
The /servers POST/PUT/DELETE handlers updated the database but left the running media-server services holding their original URL/api_key in memory, so e.g. rotating Sappho's API key in the UI looked successful but the WebSocket and HTTP polls kept presenting the old (revoked) key until the container was restarted manually. Call restartMonitoring() after each mutation to tear down WebSockets and reinit services from the updated DB rows. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The mutation handlers updated the database but left the running media-server services holding their original URL/api_key in memory. Symptom: rotating Sappho's API key in the OpsDec UI looked successful, but the WebSocket and HTTP polls kept presenting the old (revoked) key until the container was restarted manually — Sappho's red dot stayed red.
`restartMonitoring()` already exists for this purpose (used by `POST /api/monitoring/restart`); the CRUD handlers just weren't calling it.
Test plan