Repository navigation
fix: 资源图在离线时段断开、同页链接不写入历史;清理过时注释与未用代码 - #21
Merged
Merged
Conversation
- 注释对齐现状:断线后轮询间隔、bytes 与 pair 的说明(本主题没有卡片布局)、时间格式化器、请求只取所需序列、延迟提示框的数据键 - 删掉 clock 包装、axisTop 不会走到的分支与默认参数、api() 没有调用者的请求体与 204 分支,axisBytes 复用 unitOf - 五个提示框共用一份设置,四个资源图共用一次算好的时间轴 - percent 不再封顶,进度条自己止于满格,流量提示改用它 - 删掉类型里没人读的字段,以及表格、输入框、按钮里从未命中的模板样式和 --secondary 等变量,CSS 从 33.6 kB 降到 30.8 kB - .tnum 换成 Tailwind 自带的 tabular-nums
- 资源图在节点离线的时段断开,不再画成一条直线;间隔超过常规间隔(取较小的中位数)两倍才断开,上报间隔较长的 agent 不受影响,坐标轴仍按真实数据计算 - 站名、首页、监控与节点列表里指向当前页面的链接不再重复写入浏览历史,返回键一次回到上一页
- 节点离线后刚恢复、只有一个桶的数据时,这个点原来在四个资源图上都看不见,现在画成与线同色的小圆点 - 判断是否为当前页时连同查询串与锚点一起比较,从带参数的链接点站名会回到干净的地址 - 时间轴在实时推送触发的重渲染之间保持不变,四根横轴不再每次重新布局 - 删掉展开行单元格上已不起作用的 border-t-0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
全量读了一遍 serverstatus,修两处显示问题,改正与代码不符的注释,删掉用不到的代码和样式。
修复
注释
bytes、pair的说明引用的是卡片四列网格的像素数,本主题没有卡片,改为说明省下的字符换成两位小数clock和本主题没用的scale="time"s7)两处措辞,一行超宽的注释重排清理
clock包装(Intl.DateTimeFormat#format本身已绑定)、axisTop不会走到的?? target与默认参数、api()没有调用者的请求体与 204 分支、distro多余的兜底;axisBytes复用unitOfpercent不再封顶:进度条自己止于满格,流量单元格的提示原本手算百分比,改用它public、month_start、hostname、ip、github;OsIcon、Metrics不再导出;useNodes里与外层 state 同名的局部变量改名data-state、caption、file:、aria-invalid、disabled、展开行的border-t-0),以及--secondary与三个圆角变量;.tnum换成 Tailwind 自带的tabular-nums。CSS 从 33.6 kB 降到 30.8 kB测试
npm run lint、npm test(UTC 与纽约时区)、npm run build通过;新增断线的用例,阈值改为一倍、中位数改为最小值或较大的中位数时各自变红/?utm=x点站名回到/,再点不再增加