Repository navigation
refactor(install): 去掉取密码时回退读 journal 的过渡代码 - #32
Merged
Merged
Conversation
v1.2.0 发布后，安装器下载的二进制都支持 --reset-password，回退分支不会再走到。首次安装调用 --reset-password 不再静音：失败时 hub 自己的报错会显示出来。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改了什么
install-hub.sh首次安装取密码时，--reset-password失败会回退去读 journal。这段是 #16 为「脚本已合并、新版本还没发布」那段时间留的：那时下载到的 v1.1.0 不认这个参数。v1.2.0 已经发布，安装器从 latest release 下载的二进制都支持
--reset-password，回退不会再走到，这里删掉：started时间戳和读 journal 的回退分支--reset-password不再把 stderr 静音：失败时 hub 自己的报错会显示出来，密码一栏仍提示重跑安装器选「重置密码」验证
sh -n通过，shellcheck 与改动前一样只有两条原有的 SC2015 提示。Ubuntu 24.04 + systemd 容器里用本分支的脚本从 GitHub 安装 v1.2.0：
Storage=none