Repository navigation
chore: 修正与代码不符的注释，删掉面板用不到的排序写入和死分支 - #87
Merged
Merged
Conversation
- 注释改正：请求体上限、分片上限、压缩层对备份的说明、导出走独立连接、迁移所在函数、 Throttle 的两个用途、--site 报错的去向；agent 转发处的 ponytail 不再把已否决的方案写成升级方向 - 回忆式写法改成「否则会怎样」 - NodePatch 去掉 sort：面板从不发送，且它能绕过排序接口「必须列全」的校验 - 面板删掉 token 为空的死分支和重复的节点排序；/api/nodes 直接复用缓存帧，不再复制 - 一条中文日志改为英文，测试里重复的断言合并
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
通读 hub 源码、面板和安装脚本后的清理，不改任何功能。
注释改正
MAX_CHUNK（8 MiB），4 MiB 是面板每片的大小db_backup：导出走自己的连接，不占 agent 写入那条ping_record的重建在migrate_to_1，不在open()；Throttle有登录与注册两份；Scratch测试辅助的用途install-hub.sh：--site不合法时，面板现在会直接指出--siteponytail：保留缺口说明，钉摘要的方案写成「评估后未采用」及理由删掉的
NodePatch.sort：面板从不发送；它还能绕过排序接口「必须列全所有节点」的校验。PUT /api/nodes/{id}带上的sort从此被忽略，节点顺序只走PUT /api/nodes/ordertoken列非空，1.0.0 以来每个节点都有App.tsx对节点的二次排序：hub 返回时已经是sort, id顺序；面板的Node类型随之去掉不再读取的sort/api/nodes每次复制整份缓存帧，改为直接复用其它
frontend.rs里一条中文日志改为英文；测试里一条重复断言合并，一段被 rustfmt 挤歪的注释理顺验证：
cargo test（132 通过）、cargo clippy --all-targets、cargo fmt --check、面板npm test/lint/build；本地起 hub 请求/api/nodes，返回 200、application/json。