op_per_sec is replaced by read_op_per_sec and write_op_per_sec#1
Open
wwdillingham wants to merge 1 commit intomonitoring-ng:masterfrom
Open
op_per_sec is replaced by read_op_per_sec and write_op_per_sec#1wwdillingham wants to merge 1 commit intomonitoring-ng:masterfrom
wwdillingham wants to merge 1 commit intomonitoring-ng:masterfrom
Conversation
wwdillingham
commented
Jun 16, 2016
- op_per_sec is not available in "ceph status --format json" from which this collector parses
- read_op_per_sec and write_op_per_sec are available metrics and are used instead
- op_per_sec is not available in "ceph status --format json" from which this collector parses - read_op_per_sec and write_op_per_sec are available metrics and are used instead
Member
|
This is only true for current ceph releases. They switched to that format a while ago. So we need something that checks which of the two formats is in place and than use it accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.