Generalize HasBuilder to enable modelling infallible constructors (for NewtypeWrapped in contrast to NewValidated)#174
Open
sideeffffect wants to merge 2 commits intomonix:mainfrom
Open
Conversation
…r NewtypeWrapped in contrast to NewValidated)
Member
|
Hey, thanks for the PR. Can you explain where having infallible constructors would help? |
Author
|
For usage with implicit class CoerceFOps[F[_], A](private val self: F[A]) extends AnyVal {
def coerce[B](
implicit
extractor: HasExtractor.Aux[B, A],
builder: HasBuilder.Aux[B, Nothing, A],
): F[B] = self.asInstanceOf[F[B]]
} |
Author
|
What do you think @alexandru , is this a sensible approach? |
Author
|
Before we did it like this implicit class CoerceFOps[F[_], A](private val self: F[A]) extends AnyVal {
def coerce[B <: NewtypeWrapped[A]#Type]: F[B] = self.asInstanceOf[F[B]]
}but we felt that it's cleaner to use the |
Member
|
I'm thinking yes, but let me think about it. I'm taking a look tonight, to play around with the code. |
Author
|
Hello @alexandru , have you had a chance to consider this PR for merging? 😺 |
cc3289c to
b28e2fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @lgmyrek