fix(friendlist): handle legacy pbs in friendlist frontend (show less details) (@wradion) #7296
+25
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehmer
previously approved these changes
Dec 29, 2025
Contributor
Author
|
Sorry I was fighting with the trailing comma, because I've seen in the guidelines there shouldn't be one (but I guess it just applies strictly to JSON files), and I didn't know/understood right away that the linter would add it automatically. I'm so sorry, it just messes up the history of the PR and triggered builds for nothing. |
Leonabcd123
reviewed
Dec 29, 2025
frontend/src/ts/pages/friends.ts
Outdated
| if (entry.raw) { | ||
| details.push(`${result.raw} raw`); | ||
| } | ||
| if (entry.consistency) { |
Contributor
There was a problem hiding this comment.
This will not show consistency when it's 0%. Let's use a more specific if statement:
if (entry.consistency != null)
Contributor
Author
There was a problem hiding this comment.
The linter doesn't let me use !=, so I did a check on 0 instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show less details for legacy PBs in the friendlist.
Checks