Changes specific to the use with ESP32 MCUs - #1
Open
fdxrate wants to merge 5 commits into
Open
Conversation
Author
|
Hi, the first commit description about using the DeviceOpCode is possibly misleading as in the 'begin' section to set haen DeviceOpCode is not needed. I have tested your code and it does work correctly to set haen. In my pull request I have simply replaced your code with the function available in the .cpp file to simplify the code. Initially when I thought your haen code was not working it turned out to be the CS pinmode was not initialised at that stage, which I think is purely an ESP32 requirement. I like the new constructor which now includes the SPI_class and the HAEN logic, allowing for greater flexible of use. Thanks for your input and it all seems to be working just fine now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in this Pull request do not correct any errors or mistakes in the library but rather are made to enable the library to be used with ESP32 mcu's specifically. The library as it is, communicates correctly with all the registers including MCP23S08_IOCON.