Skip to content

Refactor setup CLI around new configuration framework #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
monozoide wants to merge 2 commits into
base: refactor/69-setup-process-ux-improvement
Choose a base branch
from
Draft

Refactor setup CLI around new configuration framework #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38a503c
Refactor setup workflow with new configuration system
monozoide Oct 22, 2025
0f8e049
Fix setup invocation arguments
monozoide Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions bin/maillogsentinel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,19 +162,16 @@ def main():
sys.exit(1)

setup_source_config_path_str: str
setup_mode_flag_str: str

if config_file_explicitly_passed:
setup_source_config_path_str = str(config_file_path_for_ops)
setup_mode_flag_str = "--automated"
progress_tracker.print_message( # Updated call
f"Attempting automated setup using configuration file: {setup_source_config_path_str}",
level="info",
)
else:
# For interactive setup, DEFAULT_CONFIG_PATH is the *target* configuration file.
setup_source_config_path_str = str(DEFAULT_CONFIG_PATH)
setup_mode_flag_str = "--interactive"
progress_tracker.print_message(
"Starting interactive setup process...", level="info"
) # Updated call
Expand All @@ -187,9 +184,13 @@ def main():
process_args = [
sys.executable,
str(setup_script_path),
"--config",
setup_source_config_path_str,
setup_mode_flag_str,
]
if config_file_explicitly_passed:
process_args.append("--non-interactive")
else:
process_args.append("--interactive")
process = subprocess.Popen(
process_args
) # stdout/stderr go to parent's by default
Expand Down
Loading