url: drop the dead moonbitlang/core/strconv import; release 0.15.5 - #168
Merged
Conversation
`url/moon.pkg` imported both `moonbitlang/core/strconv` and `moonbitlang/core/string`, and the one parse in the package (`url.mbt`, the port) already goes through `@string.parse_int`. Nothing named `@strconv`; the import was dead. It stopped being harmless with core 0.10.12, which removed `moonbitlang/core/strconv` (only `core/internal/strconv` remains): any module depending on rabbita then fails package solving before a single file is compiled — "Cannot find import 'moonbitlang/core/strconv' in moonbit-community/rabbita/url". `core/string` carries the same `parse_*` API in 0.10.11 and 0.10.12, so this builds on both. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FXBYcYo74F1DGSPZsYYAdc
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
url/moon.pkgimported bothmoonbitlang/core/strconvandmoonbitlang/core/string; the package's one parse (url.mbt, the port) already uses@string.parse_int. Nothing referenced@strconv— the import was dead.It stopped being harmless with core 0.10.12, which removed
moonbitlang/core/strconv(onlycore/internal/strconvremains). Any module depending on rabbita then fails package solving before compiling anything:core/stringhas the sameparse_*API in 0.10.11 and 0.10.12, so this builds on both. Version bumped to 0.15.5 for the release tagrabbita-v0.15.5.Note: rabbita's own dependency
oboard/mocket@0.7.7also imports the removed package, so this module still won't solve on core 0.10.12 until mocket releases a fix — this PR removes rabbita's share of the problem.🤖 Generated with Claude Code
https://claude.ai/code/session_01FXBYcYo74F1DGSPZsYYAdc