chore: format the workspace - #172
Merged
Merged
Conversation
`publish.yml` runs `moon fmt --check`, which scans every `moon.work`
member, and it failed on `e2e/apps/forms-and-events/model.mbt` — blocking
the 0.15.6 release on the formatting of a file that is not part of the
published package.
`check.yml` never caught the drift because it runs `moon fmt .`, scoped to
the `rabbita` module, so 79 files across `doc/`, `e2e/`, `examples/`,
`rui/`, `warren/`, `website/` and `rabbita/` itself had drifted from what
the current toolchain (moon 0.1.20260827, moonc v0.10.11+6ff76a5f9) emits.
Every change is a trailing comma inside a brace-delimited literal, e.g.
`{ protocol, host, port, path, query, fragment }` gaining a `,`. Normalizing
whitespace and trailing commas leaves no unpaired line in the diff, and
`moon check` on js, native and wasm plus 86 native tests are unchanged.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AmoyPMELemz5hdNNdXyAkm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the 0.15.6 release. The
rabbita-v0.15.6publish run failed at Check formatting — one2e/apps/forms-and-events/model.mbt, a file that is not part of the published package.Why CI never caught this
The two workflows invoke the formatter differently:
check.ymlmoon fmt .rabbitamodule onlypublish.ymlmoon fmt --checkmoon.workmemberSo drift anywhere in
doc/,e2e/,examples/,rui/,warren/orwebsite/is invisible to PR CI and only surfaces when someone cuts a release. 79 files had drifted from what the current toolchain emits.Worth noting
moon fmt --checkscans the whole workspace even when run fromrabbita/withworking-directory: rabbita, which is why this reads as a rabbita release gate but isn't one.The change is entirely trailing commas
Every hunk adds a
,inside a brace-delimited literal:79 files, +497/-495. Normalizing whitespace and trailing commas leaves no unpaired line in the diff, so there is no semantic change.
Verification
Toolchain matched to CI exactly (moon 0.1.20260827, moonc v0.10.11+6ff76a5f9):
moon check— pass on js, native, wasmmoon test— 86 passed, nativemoon fmtis at a fixed point (re-running produces nothing further)Both workflows' gates simulated locally against this commit, all exit 0:
moon fmt .+git diff --exit-code(check.yml)moon info . --target js+git diff --exit-code(check.yml)moon check --target all --deny-warn(publish.yml)moon fmt --check(publish.yml)Once this lands I'll move the
rabbita-v0.15.6tag onto it and re-run the publish. Nothing was published by the failed run —Publish to MooncakesandCreate GitHub Releasewere both skipped, and the registry still has ≤ 0.15.4.🤖 Generated with Claude Code
https://claude.ai/code/session_01AmoyPMELemz5hdNNdXyAkm