Skip to content

chore: format the workspace - #172

Merged
bobzhang merged 1 commit into
mainfrom
chore/format-workspace
Sep 5, 2026
Merged

chore: format the workspace#172
bobzhang merged 1 commit into
mainfrom
chore/format-workspace

Conversation

@bobzhang

@bobzhang bobzhang commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Unblocks the 0.15.6 release. The rabbita-v0.15.6 publish run failed at Check formatting — on e2e/apps/forms-and-events/model.mbt, a file that is not part of the published package.

Why CI never caught this

The two workflows invoke the formatter differently:

workflow command scope
check.yml moon fmt . the rabbita module only
publish.yml moon fmt --check every moon.work member

So drift anywhere in doc/, e2e/, examples/, rui/, warren/ or website/ is invisible to PR CI and only surfaces when someone cuts a release. 79 files had drifted from what the current toolchain emits.

Worth noting moon fmt --check scans the whole workspace even when run from rabbita/ with working-directory: rabbita, which is why this reads as a rabbita release gate but isn't one.

The change is entirely trailing commas

Every hunk adds a , inside a brace-delimited literal:

-  { protocol, host, port, path, query, fragment }
+  { protocol, host, port, path, query, fragment, }
-    InputChanged(value) => { ..model, text: value }
+    InputChanged(value) => { ..model, text: value, }

79 files, +497/-495. Normalizing whitespace and trailing commas leaves no unpaired line in the diff, so there is no semantic change.

Verification

Toolchain matched to CI exactly (moon 0.1.20260827, moonc v0.10.11+6ff76a5f9):

  • moon check — pass on js, native, wasm
  • moon test — 86 passed, native
  • moon fmt is at a fixed point (re-running produces nothing further)

Both workflows' gates simulated locally against this commit, all exit 0:

  • moon fmt . + git diff --exit-code (check.yml)
  • moon info . --target js + git diff --exit-code (check.yml)
  • moon check --target all --deny-warn (publish.yml)
  • moon fmt --check (publish.yml)

Once this lands I'll move the rabbita-v0.15.6 tag onto it and re-run the publish. Nothing was published by the failed run — Publish to Mooncakes and Create GitHub Release were both skipped, and the registry still has ≤ 0.15.4.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AmoyPMELemz5hdNNdXyAkm

`publish.yml` runs `moon fmt --check`, which scans every `moon.work`
member, and it failed on `e2e/apps/forms-and-events/model.mbt` — blocking
the 0.15.6 release on the formatting of a file that is not part of the
published package.

`check.yml` never caught the drift because it runs `moon fmt .`, scoped to
the `rabbita` module, so 79 files across `doc/`, `e2e/`, `examples/`,
`rui/`, `warren/`, `website/` and `rabbita/` itself had drifted from what
the current toolchain (moon 0.1.20260827, moonc v0.10.11+6ff76a5f9) emits.

Every change is a trailing comma inside a brace-delimited literal, e.g.
`{ protocol, host, port, path, query, fragment }` gaining a `,`. Normalizing
whitespace and trailing commas leaves no unpaired line in the diff, and
`moon check` on js, native and wasm plus 86 native tests are unchanged.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AmoyPMELemz5hdNNdXyAkm
@bobzhang
bobzhang merged commit b129194 into main Sep 5, 2026
5 checks passed
@bobzhang
bobzhang deleted the chore/format-workspace branch September 5, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant