Ds camera - #5
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances camera control and player animation logic in DungeonStomp. The changes focus on camera angle clamping to prevent extreme vertical look angles and refinements to player animation sequence updates to avoid redundant calls.
Key changes:
- Added camera vertical look angle clamping to prevent exceeding ±89.3 degrees
- Refined player animation sequence logic to prevent unnecessary updates
- Minor whitespace cleanup
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (look_up_ang < -89.3f) | ||
| look_up_ang = -89.3f; | ||
|
|
||
| if (look_up_ang > 89.3f) | ||
| look_up_ang = 89.3f; |
There was a problem hiding this comment.
This camera angle clamping logic is duplicated from earlier in the same function (lines 5094-5098 in FrameMove2). The same clamping constraints for look_up_ang are applied in both locations. Consider whether this duplication is necessary - if both camera calculations need clamping, a helper function or a single clamping point might be more maintainable.
No description provided.