Skip to content

Changing Datatable Highlighting and Text Color#76

Open
sandertyu wants to merge 1 commit intomoorepants:masterfrom
sandertyu:data-color
Open

Changing Datatable Highlighting and Text Color#76
sandertyu wants to merge 1 commit intomoorepants:masterfrom
sandertyu:data-color

Conversation

@sandertyu
Copy link
Collaborator

The goal here is to change the datatable styling so that when cells are selected, the background color does not change and the text color does not change. Currently on live, the background color becomes a whitish-pink, and the text-color changes to match the unselected grey background color, making the text nearly illegible. My changes here remove the background color changes entirely. The selected cell looks like this;

data-color

This pull request will be good to merge once the text color changes are fixed. Alternatively, we can keep the background color changes when selected. However, the font color is still difficult to read except when hovering over a selected cell. The full issue is available here at #68

@moorepants
Copy link
Owner

@sandertyu Is this ready to be merged? I forgot about this.

@sandertyu
Copy link
Collaborator Author

Sorry, I saw the email and then forgot to comment. This is not ready to be merged. The current state of this PR is exactly as the image shows; I've removed background highlighting, but the text is unreadable when you select a cell. To be ready to merge, the text color needs to be changed when selected. I detailed the exact CSS to do that in issue #68 , but when I actually implemented it in the CSS file, it did not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants