Changing Datatable Highlighting and Text Color#76
Open
sandertyu wants to merge 1 commit intomoorepants:masterfrom
Open
Changing Datatable Highlighting and Text Color#76sandertyu wants to merge 1 commit intomoorepants:masterfrom
sandertyu wants to merge 1 commit intomoorepants:masterfrom
Conversation
Owner
|
@sandertyu Is this ready to be merged? I forgot about this. |
Collaborator
Author
|
Sorry, I saw the email and then forgot to comment. This is not ready to be merged. The current state of this PR is exactly as the image shows; I've removed background highlighting, but the text is unreadable when you select a cell. To be ready to merge, the text color needs to be changed when selected. I detailed the exact CSS to do that in issue #68 , but when I actually implemented it in the CSS file, it did not work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal here is to change the datatable styling so that when cells are selected, the background color does not change and the text color does not change. Currently on live, the background color becomes a whitish-pink, and the text-color changes to match the unselected grey background color, making the text nearly illegible. My changes here remove the background color changes entirely. The selected cell looks like this;
This pull request will be good to merge once the text color changes are fixed. Alternatively, we can keep the background color changes when selected. However, the font color is still difficult to read except when hovering over a selected cell. The full issue is available here at #68