Skip to content

Feature allow changing caching strategy#59

Open
kaykaul wants to merge 4 commits into
moozzyk:masterfrom
kaykaul:feature/allow-changing-caching-strategy
Open

Feature allow changing caching strategy#59
kaykaul wants to merge 4 commits into
moozzyk:masterfrom
kaykaul:feature/allow-changing-caching-strategy

Conversation

@kaykaul
Copy link
Copy Markdown

@kaykaul kaykaul commented Aug 3, 2023

Motivation:

  1. I'm using Easycaching.Redis as caching provider, and I'm getting the error in CachingReader class when trying to cast a DBNull value into a primitive type like string.
  2. I want to change the CachedResult type into a more json/messagepack serializer friendly class.
  3. I want to try using DataTable.CreateDataReader as the data reader instead of CachingReader.

I've tried to be backwards compatible.
Request you to accept this PR or provide any comments on improvement.

Thank you for creating this library. I'm open to contribute a small amount if you're okay with it.

keshav added 3 commits August 4, 2023 10:41
CachingCommandStrategy should not have access to ExecuteDbDataReader
Rename _command to _commandMetadata
@kaykaul kaykaul force-pushed the feature/allow-changing-caching-strategy branch from c1520b4 to afafafd Compare August 4, 2023 10:49
…endence on feature/use-generic-cache-interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant