Make Jetty HTTP client compliance configurable via system property#724
Merged
acetousk merged 1 commit intoJun 24, 2026
Merged
Conversation
Jetty 12's HttpClient defaults to HttpCompliance.RFC9110, which strictly
rejects response headers containing quoted characters in token positions
(BAD_QUOTES_IN_TOKEN). Some external APIs such as Shopify return Set-Cookie
response headers that violate this rule, causing RestClient to throw a
BaseException and fail the request even though credentials and payload are valid.
Added support for a JVM system property moqui.http.client.compliance that
is read once when SimpleRequestFactory initializes the shared HttpClient.
When set, the specified compliance mode is applied to the HttpClient before
it starts, making the behavior configurable without code changes.
To allow BAD_QUOTES_IN_TOKEN violations (e.g. for Shopify):
-Dmoqui.http.client.compliance=RFC7230
Valid values: RFC9110 (Jetty default), RFC7230, RFC2616, RFC2616_LEGACY,
LEGACY, STRICT
Also improved callInternal() error logging to surface the root cause of
HTTP transport failures directly in the log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jetty 12's HttpClient defaults to HttpCompliance.RFC9110, which strictly
rejects response headers containing quoted characters in token positions
(BAD_QUOTES_IN_TOKEN). Some external APIs such as Shopify return Set-Cookie
response headers that violate this rule, causing RestClient to throw a
BaseException and fail the request even though credentials and payload are valid.
Added support for a JVM system property moqui.http.client.compliance that
is read once when SimpleRequestFactory initializes the shared HttpClient.
When set, the specified compliance mode is applied to the HttpClient before
it starts, making the behavior configurable without code changes.
To allow BAD_QUOTES_IN_TOKEN violations (e.g. for Shopify):
-Dmoqui.http.client.compliance=RFC7230
Valid values: RFC9110 (Jetty default), RFC7230, RFC2616, RFC2616_LEGACY,
LEGACY, STRICT