Add isBirthday and isSameAsmethod to Jalalian class#199
Closed
alissn wants to merge 2 commits intomorilog:masterfrom
Closed
Add isBirthday and isSameAsmethod to Jalalian class#199alissn wants to merge 2 commits intomorilog:masterfrom
isBirthday and isSameAsmethod to Jalalian class#199alissn wants to merge 2 commits intomorilog:masterfrom
Conversation
Owner
|
its not necessary methods for this package, so i reject the PR |
Author
|
Hi, @morilog The reason for this PR is that, AYK in Gregorian leap years, birthdays can shift by one day when converting between calendars. For example, if my birthday is stored in the database as
In Laravel applications, date fields are often cast as This method helps handle such cases correctly . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
isBirthdaymethod to Jalalian class based on Carbon's implementation. Compares month and day values while ignoring year, perfect for birthday comparisons in Jalali calendar.Changes
isSameAs()method: Compares formatted date values with flexible format supportisBirthday()method: Checks if dates share same month/day (birthday comparison)Usage