Conversation
- Add comprehensive .eslintrc.json for examples directory with Node.js and ES2020 support - Configure ESLint overrides for Electron renderer and Next.js environments - Remove unused formatPlain import from CLI tool count command - Remove unused ORDER_STATUSES import from orders service - Rename unused passwordHash variables to _hash in users service to follow convention - Add ESLint disable comment for intentional unused next parameter in error handler - Expand CI matrix to include Node.js 24.x for broader version coverage
- Increase minimum lockTimeoutMs arbitrary from 1 to 100ms to avoid race conditions with very small timeout values - Replace lockTimeoutMs - delta calculation with Math.min(delta, Math.floor(lockTimeoutMs / 2)) to guarantee lock age stays well within timeout window - Add clarifying comments explaining why lockTimeoutMs / 2 is used to prevent Date.now() drift between test setup and isTimedOut() check from causing flaky failures - Apply timing fix consistently across both non-stale detection test cases (standard and CI environments)
- Add assertion to verify stdout is not empty before parsing JSON - Guard against child_process stdout not being fully flushed on CI - Prevents parsing errors on Node 18 + macOS ARM64 runners - Ensures test reliability across different CI environments
…dation - Add early exit condition when B contains scalar value at merge key - Skip subtree traversal when B's scalar replaces A's entire object structure - Prevent false negatives in property test by handling scalar-over-object replacement - Ensures merge priority rules are correctly validated during deep object merging
…r-pre-release-fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Resolves 17 ESLint errors that caused CI lint step failure on the examples directory.
Changes
examples/.eslintrc.json(new) — ESLint configuration for the examples directory:sourceType: moduleto support ESMimport/exportsyntax used by Next.js example filesbrowserenvironment override for07-electron-desktop-app/src/renderer/(enablesdocument,windowglobals)09-next-webapp/files (ecmaFeatures.jsx: true)no-unused-varswithargsIgnorePattern: ^_andvarsIgnorePattern: ^_|^[A-Z]for JSX component importsexamples/04-cli-tool/src/commands/count.js— removed unusedformatPlainimport (onlyformatTableis used)examples/10-enterprise-platform/src/domains/orders/orders.service.js— removed unusedORDER_STATUSESimport (onlySTATUS_TRANSITIONSis used)examples/10-enterprise-platform/src/domains/users/users.service.js— renamed destructuredpasswordHashto_hashin two locations to satisfyno-unused-vars(the variable is intentionally discarded when returning safe user objects)examples/10-enterprise-platform/src/shared/middleware/error-handler.js— addedeslint-disable-next-line no-unused-varsfor the Express error handler's 4thnextparameter (Express requires the 4-argument signature to identify error middleware, but the parameter is not used in the body).github/workflows/ci.yml— added Node.js 24.x to the CI test matrix (18.x = minimum supported, 22.x = Active LTS, 24.x = Current)