fix: handle paginated documents response and non-localhost auth guard (issue 378 and 379)#389
Open
Tyrannius wants to merge 2 commits intomorphik-org:mainfrom
Open
fix: handle paginated documents response and non-localhost auth guard (issue 378 and 379)#389Tyrannius wants to merge 2 commits intomorphik-org:mainfrom
Tyrannius wants to merge 2 commits intomorphik-org:mainfrom
Conversation
|
|
Author
|
on a note: @DevDesai444 made a PR on those issues I posted 3 days ago (inluding the fix) but closed them again. I reopened them now as they helped me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #378
Fixes #379
Changes
PDFViewer.tsx — handle paginated /documents response
The PDF Viewer assumed POST /documents returns a plain array.
The backend now returns
{ documents: [...] }. This fix handles both formats.ChatSection.tsx — fix document selector in non-localhost deployments
The fetch guard
apiBaseUrl.includes("localhost")silently blockeddocument loading for all non-localhost deployments with bypass_auth_mode.
Changed to
apiBaseUrlwhich is sufficient since the function alreadyguards against falsy apiBaseUrl internally.