Handle malformed WarpGrep Windows results gracefully#8
Merged
DhruvBhatia0 merged 4 commits intomainfrom Mar 30, 2026
Merged
Conversation
Fixes #7 — On Windows, upstream SDK path parsing truncates drive-letter paths (e.g. C:/Users/.../auth.ts → file: 'C'), producing confusing output. This adds detection for malformed contexts and surfaces an actionable error with a workaround suggestion. Also fixes the 'Search failed: undefined' output when the SDK omits an error string. https://claude.ai/code/session_01G5qa1GyHGNwWu2ko6uZ53N
Validate that search result file paths are plausible (contain a path separator or dot-extension with non-empty content) rather than checking for a specific truncation pattern. Tests cover paths from all major OS conventions. https://claude.ai/code/session_01G5qa1GyHGNwWu2ko6uZ53N
Includes upstream fix for Windows drive-letter path parsing in parseFinishFiles. https://claude.ai/code/session_01G5qa1GyHGNwWu2ko6uZ53N
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Search failed: undefinedwhen the SDK omits an error stringChanges
index.tsisValidContext()— checks that a file path contains a separator (/or\) or a dot-extension, and that content is non-emptyformatWarpGrepResult()now filters contexts through validation; if none survive, returns an actionable error with the malformed file valuesresult.errorvalues (undefined,null,"") no longer surface literally — a fallback message is used insteadindex.test.ts"C",""," ","noextension") are rejected; valid paths across all OS conventions (unix relative/absolute, Windows absolute/relative,../,./, dot-extension-only) render normallyundefined/null; explicit errors pass through exactlyTest plan
bun test— all new tests pass, no regressionshttps://claude.ai/code/session_01G5qa1GyHGNwWu2ko6uZ53N